From 2fe3e0b8ee15ac99025f1e4ebca8b147f97be1e1 Mon Sep 17 00:00:00 2001 From: pictuga Date: Tue, 26 May 2020 19:26:36 +0200 Subject: [PATCH] feeds: clean up other stylesheets before putting ours --- morss/feeds.py | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/morss/feeds.py b/morss/feeds.py index 13cb760..65ada53 100644 --- a/morss/feeds.py +++ b/morss/feeds.py @@ -718,11 +718,29 @@ class Item(Uniq): class FeedXML(Feed, ParserXML): itemsClass = 'ItemXML' + def root_siblings(self): + out = [] + current = self.root.getprevious() + + while current is not None: + out.append(current) + current = current.getprevious() + + return out + def tostring(self, encoding='unicode', **k): # override needed due to "getroottree" inclusion + # and to add stylesheet - if self.root.getprevious() is None: - self.root.addprevious(etree.PI('xml-stylesheet', 'type="text/xsl" href="/sheet.xsl"')) + stylesheets = [x for x in self.root_siblings() if isinstance(x, etree.PIBase) and x.target == 'xml-stylesheet'] + + if len(stylesheets): + # remove all stylesheets present (be that ours or others') + for stylesheet in stylesheets: + self.root.append(stylesheet) # needed as we can't delete root siblings https://stackoverflow.com/a/60232366 + self.root.remove(stylesheet) + + self.root.addprevious(etree.PI('xml-stylesheet', 'type="text/xsl" href="/sheet.xsl"')) return etree.tostring(self.root.getroottree(), encoding=encoding, method='xml', **k)