pictuga
/
morss
1
1
Fork 0
Code Issues Pull Requests Actions Packages Releases Activity

Safer Cache saving 

Create tmp file and then move it to destination. Avoids corrupt files during write
master
pictuga 2014-01-29 20:36:45 +01:00
parent 6eaec96af7
commit 6c33bb6e1c
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
morss/morss.py
View File

@ -138,10 +138,11 @@ class Cache:
self._dir = folder self._dir = folder
self._dic = dic self._dic = dic
maxsize = os.statvfs('./').f_namemax - len(self._dir) - 1 maxsize = os.statvfs('./').f_namemax - len(self._dir) - 1 - 4 # ".tmp"
self._hash = urllib.quote_plus(self._key)[:maxsize] self._hash = urllib.quote_plus(self._key)[:maxsize]
self._file = self._dir + '/' + self._hash self._file = self._dir + '/' + self._hash
self._file_tmp = self._file + '.tmp'
self._cached = {} # what *was* cached self._cached = {} # what *was* cached
self._cache = {} # new things to put in cache self._cache = {} # new things to put in cache
@ -188,8 +189,13 @@ class Cache:
out = json.dumps(self._cache, indent=4) out = json.dumps(self._cache, indent=4)
with open(self._file, 'w+') as file: try:
file.write(out) open(self._file_tmp, 'w+').write(out)
os.rename(self._file_tmp, self._file)
except IOError:
log('failed to write cache to tmp file')
except OSError:
log('failed to move cache to file')
def isYoungerThan(self, sec): def isYoungerThan(self, sec):
if not os.path.exists(self._file): if not os.path.exists(self._file):